RDM: Small issues in TS-0023 V4.8.0
The following issues were found after updating the SDT files to v4.8.
Devices
Table 5.5.1.18-1: Modules of device3DDisplay Device model
- clock : correct reference 5.3.1.18, + lower case
- audioVolume : correct reference 5.3.1.8
- 3DDisplay : correct reference 5.3.1.116, also rename to threeDDisplay
- connectivity : correct reference 5.3.1.25
- runState : correct reference 5.3.1.75
- lock : correct reference 5.3.1.52
Table 5.5.1.19-1: Modules of device3DScanner device model
- clock : correct reference reference 5.3.1.18
- 3DScanState : rename to threeDScanState
- 3DScanner : correct reference 5.3.1.117, rename to threeDScanner
- connectivity : correct reference 5.3.1.25
Table 5.5.8.3-1: Modules of deviceCardRecharingMachine Device model
- typo in Table header: deviceCardRechargingMachine
- clock : correct reference 5.3.1.18
- emergencyButton : correct reference 5.3.1.69
- keypad : correct reference 5.3.1.49
- audioVolume : correct reference 5.3.1.8
- connectivity : correct reference 5.3.1.25
- runState : correct reference 5.3.1.75
- lock : correct reference 5.3.1.52
Table 5.5.8.4-1: Modules of deviceSmartGate Device model
- clock : correct reference 5.3.1.18
- touchScreen : add "See clause 5.3.1.106"
- audioVolume : correct reference 5.3.1.8
- connectivity : correct reference 5.3.1.25
- runState : correct reference 5.3.1.75
- colour : correct reference 5.3.1.23
- colourSaturation : correct reference 5.3.1.24
- brightness : correct reference 5.3.1.17
Table 5.5.8.5-1: Modules of deviceSmartScreenDoor Device Model
- screenDoor : correct reference 5.3.1.30. Also change multiplicity to N. 2 doesn't exist! Alternative: two attributes instead of "2" with explicit functionalities
- emergencyButton : correct reference 5.4.1.69
- audioVolume : correct reference 5.3.1.8
- connectivity : correct reference 5.3.1.25
- runState : correct reference 5.3.1.75
- colour : correct reference 5.3.1.23
- colourSaturation : correct reference 5.3.1.24
- brightness : correct reference 5.3.1.17
5.3.1.116 3DDisplay
- rename to threeDDisplay (problems when turning names into code)
- rename all "3D" attributes to "threeD..."
- Add UoM to 3DDisplayResolutionX and 3DDisplayResolutionY : pixel
- Rename cod:enum3DDisplayType to hd:enum3DDisplayType
5.3.1.117 3DScanner
- rename to threeDScanner (problems when turning names into code)
- rename all "3D" attributes to "threeD..."
- rename cod:enum3DScannerType to hd:enum3DScannerType
ModuleClass
5.3.1.106 touchScreen
- What does "1..N" mean in the descriptions? Are these lists? Then the datatype must be changed.
5.3.1.107 prePaidCardReader
- What does "1..N" mean in the descriptions of "cardInfo"? Is this a list? Then the datatype must be changed
5.3.1.108 billDeposit
- What does "1..N" mean in the descriptions of "count"? Is this a list? Then the datatype must be changed
5.3.1.109 billWithdrawal
- What does "1..N" mean in the descriptions of "count"? Is this a list? Then the datatype must be changed
5.3.1.110 coinDeposit
- "coin" is not a list here.
5.3.1.111 cashDispenser
- "coin" is not a list here.
5.3.1.112 cardScanner
- What does "1..N" mean in the descriptions of "cardScanner"? Is this a list? Then the datatype must be changed
5.3.1.113 traceSensor
- Not a good name for the ModuleClass. The description suggests that the heading is measured. Suggestion: headingSensor
- At least the "heading" data point should not be optional
- Unit of measure is missing for "heading". Suggestion: degree
- Correct unit of measure for "headingAccuracy" should be "degree"
5.3.1.114 directionPanel
- Think about the name. It is basically a light switch. Also, the name of the data point "direction" is misleading. Suggestion: rename MC to "signalPanel", "direction" to "signal".
Enums
5.6.42 hd:enumDataModelType
- Spaces in names cannot be represented this way in programming.
- Proposal : Replace spaces, minus, and points with underline in hd:enumDataModelType.
5.6.52 hd:enum3DDisplayType
- Spaces in names cannot be represented this way in programming.
- Proposal : Replace spaces with underline in hd:enum3DScannerType.
5.6.53 hd:enum3DScannerType
- Spaces in names cannot be represented this way in programming.
- Proposal : Replace spaces with underline in hd:enum3DScannerType.
Table 5.6.53-1 Interpretation of cod:enum3DScannerType
- rename cod:enum3DScannerType to hd:enum3DScannerType
5.6.50 hd:enumBatteryMaterial
- Replace spaces and minus with underline in hd:enumBatteryMaterial
- Remove abbreviations, like (Li-Ion). Simplify
- Please put, if necessary, details in the descriptions, not in the names
5.6.51 hd:enumBatteryShape
- Replace spaces and minus with underline in hd:enumBatteryShape
- Please put, if necessary details in the descriptions, not in the names.